Bug Summary

File:/home/anal/dolphin-emu/Source/Core/DiscIO/Src/BannerLoaderWii.cpp
Location:line 27, column 12
Description:Function call argument is an uninitialized value

Annotated Source Code

1// Copyright 2013 Dolphin Emulator Project
2// Licensed under GPLv2
3// Refer to the license.txt file included.
4
5#include <stdio.h>
6#include <algorithm>
7
8#include "Common.h"
9#include "ColorUtil.h"
10#include "BannerLoaderWii.h"
11#include "VolumeCreator.h"
12#include "FileUtil.h"
13#include "FileHandlerARC.h"
14
15namespace DiscIO
16{
17
18CBannerLoaderWii::CBannerLoaderWii(DiscIO::IVolume *pVolume)
19 : m_pBannerFile(NULL__null)
20 , m_IsValid(false)
21{
22 char Filename[260];
23 u64 TitleID;
1
'TitleID' declared without an initial value
→
24
25 pVolume->GetTitleID((u8*)&TitleID);
26
27 TitleID = Common::swap64(TitleID);
2
←
Function call argument is an uninitialized value
28
29 sprintf(Filename, "%stitle/%08x/%08x/data/banner.bin",
30 File::GetUserPath(D_WIIUSER_IDX).c_str(), (u32)(TitleID>>32), (u32)TitleID);
31
32 if (!File::Exists(Filename))
33 {
34 // TODO(XK): Finish the 'commented' code. Turns out the banner.bin
35 // from the savefiles is very different from the banner.bin
36 // inside opening.bnr
37#if 0
38 char bnrFilename[260], titleFolder[260];
39
40 // Creating title folder
41 sprintf(titleFolder, "%stitle/%08x/%08x/data/",
42 File::GetUserPath(D_WIIUSER_IDX).c_str(), (u32)(TitleID>>32), (u32)TitleID);
43 if(!File::Exists(titleFolder))
44 File::CreateFullPath(titleFolder);
45
46 // Extracting banner.bin from opening.bnr
47 sprintf(bnrFilename, "%stitle/%08x/%08x/data/opening.bnr",
48 File::GetUserPath(D_WIIUSER_IDX).c_str(), (u32)(TitleID>>32), (u32)TitleID);
49
50 if(!_rFileSystem.ExportFile("opening.bnr", bnrFilename)) {
51 m_IsValid = false;
52 return;
53 }
54
55 CARCFile bnrArc (bnrFilename, 0x600);
56
57 if(!bnrArc.ExportFile("meta/banner.bin", Filename)) {
58 m_IsValid = false;
59 return;
60 }
61
62 // Now we have an LZ77-compressed file with a short IMD5 header
63 // TODO: Finish the job
64
65 File::Delete(bnrFilename);
66#else
67 m_IsValid = false;
68 return;
69#endif
70 }
71
72 // load the banner.bin
73 size_t FileSize = (size_t) File::GetSize(Filename);
74
75 if (FileSize > 0)
76 {
77 m_pBannerFile = new u8[FileSize];
78 File::IOFile pFile(Filename, "rb");
79 if (pFile)
80 {
81 pFile.ReadBytes(m_pBannerFile, FileSize);
82 m_IsValid = true;
83 }
84 }
85}
86
87CBannerLoaderWii::~CBannerLoaderWii()
88{
89 if (m_pBannerFile)
90 {
91 delete [] m_pBannerFile;
92 m_pBannerFile = NULL__null;
93 }
94}
95
96bool CBannerLoaderWii::IsValid()
97{
98 return m_IsValid;
99}
100
101std::vector<u32> CBannerLoaderWii::GetBanner(int* pWidth, int* pHeight)
102{
103 SWiiBanner* pBanner = (SWiiBanner*)m_pBannerFile;
104 std::vector<u32> Buffer;
105 Buffer.resize(192 * 64);
106 ColorUtil::decode5A3image(&Buffer[0], (u16*)pBanner->m_BannerTexture, 192, 64);
107 *pWidth = 192;
108 *pHeight = 64;
109 return Buffer;
110}
111
112bool CBannerLoaderWii::GetStringFromComments(const CommentIndex index, std::string& result)
113{
114 if (IsValid())
115 {
116 auto const banner = reinterpret_cast<const SWiiBanner*>(m_pBannerFile);
117 auto const src_ptr = banner->m_Comment[index];
118
119 // Trim at first NULL
120 auto const length = std::find(src_ptr, src_ptr + COMMENT_SIZE, 0x0) - src_ptr;
121
122 std::wstring src;
123 src.resize(length);
124 std::transform(src_ptr, src_ptr + src.size(), src.begin(), (u16(&)(u16))Common::swap16);
125 result = UTF16ToUTF8(src);
126
127 return true;
128 }
129
130 return false;
131}
132
133std::vector<std::string> CBannerLoaderWii::GetNames()
134{
135 std::vector<std::string> ret(1);
136
137 if (!GetStringFromComments(NAME_IDX, ret[0]))
138 ret.clear();
139
140 return ret;
141}
142
143std::string CBannerLoaderWii::GetCompany()
144{
145 return "";
146}
147
148std::vector<std::string> CBannerLoaderWii::GetDescriptions()
149{
150 std::vector<std::string> result(1);
151 if (!GetStringFromComments(DESC_IDX, result[0]))
152 result.clear();
153 return result;
154}
155
156} // namespace